-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading issues related to <picture> elements? #1305
Comments
In Firefox (since version 131.0), when selector.find('img:not([src=""]), iframe').each(function() {
$(this).one('load error', function() {
if (++count === total) { callback(); }
}).each(function() {
if (this.complete || this.src == '') { $(this).trigger('load'); }
});
}); |
Aha, thank you so much for the explanation! Sorry I'm a huge amateur, but is this code block a fix? I tried copypasting it and changing |
I'm not offering a solution to the problem; I just wanted to clarify what the issue is and in which part of the library's code it occurs, as I'm dealing with it too. Maybe it's not even a problem with bxSlider, but with Firefox—I don't know. |
Firefox now seems to set img.complete on the next frame.
|
My slider loads just fine at first, but from the second load (whether you go to another page and come back, refresh, etc.) you get an eternal loading symbol.
The really weird thing is that you can fix it by resizing the page? There's a breakpoint at 600px wide where the
<picture>
selects a different image source, and if you resize the window past that point, it fixes the slider completely. It seems the bxSlider isn't adding the necessary tags to my slider div until that resize (see the images below).I restructured my site some time ago to use these
<picture>
elements with the breakpoints; I believe it didn't break until very recently, but I could be wrong.Before resizing:
After resizing:
The text was updated successfully, but these errors were encountered: