Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFN ChangeSets are failing #57

Open
scottnixonjr opened this issue Apr 6, 2020 · 4 comments
Open

CFN ChangeSets are failing #57

scottnixonjr opened this issue Apr 6, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@scottnixonjr
Copy link

scottnixonjr commented Apr 6, 2020

Deploying the mutato-example-basic app.

Steps to reproduce:

  1. Make changes to the index.html
  2. commit changes, update github.
  3. Branch triggers the Pipeline deployment.
  4. Verify if changes to index.html by opening the Http endpoint in the CFN Output section.

The deployed version on each ECS Service are from the 1st successful deployment.

The Pipeline shows success on both stages. However, the CFN ChangeSets are failing. The submitted information didn't contain changes. Submit different information to create a change set.

Minor details that might be helpful.
1st deployment - original file without changes.
2nd deployment - added paragraph “The name is an x-files reference”
3rd deployment - added “3rd Deployment”
Here is repo I’m deploying.

@3p3r 3p3r added the bug Something isn't working label Apr 7, 2020
@3p3r 3p3r self-assigned this Apr 7, 2020
@3p3r
Copy link
Contributor

3p3r commented Apr 7, 2020

I discovered why it's not updating your deploys. the images are being pushed to ECR, I am using the latest tag in the service definition. therefore the underlying ECS cluster is not updated. I fixed it in 0b4ce2a
will bundle it in a patch release soon.

@3p3r
Copy link
Contributor

3p3r commented Apr 7, 2020

the "ChangeSets are failing" part is normal. because there were no actual changes, the change set generation fails.

@3p3r
Copy link
Contributor

3p3r commented Apr 9, 2020

I believe I have fixed this issue in the develop branch, specifically within the following commits:

Here is how I tested:

  1. I emptied our dev account
  2. I made a develop branch over at https://github.com/stelligent/mutato-example-basic/tree/develop
  3. I used the current stelligent/mutato:develop image to deploy the branch clean
  4. I pushed this commit and waited for pipeline to finish
  5. verified that nginx is showing the right content
  6. I pushed this commit and waited for pipeline to finish
  7. verified that nginx is showing the right content

I'll let @scottnixonjr test it again clean before closing this issue and merging into master.

@scottnixonjr
Copy link
Author

I was able to deploy an update to the existing Stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants