Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot Archive Restores are not applied immediately during ledger #4638

Closed
SirTyson opened this issue Feb 4, 2025 · 0 comments · Fixed by #4639
Closed

Hot Archive Restores are not applied immediately during ledger #4638

SirTyson opened this issue Feb 4, 2025 · 0 comments · Fixed by #4639
Assignees
@SirTyson
Labels
bug

Comments

@SirTyson
Copy link
Contributor

SirTyson commented Feb 4, 2025

Currently in protocol 23, there is a bug where restores from the Hot Archive cannot be used by later transactions within the same ledger. This should be fixed.
@SirTyson SirTyson added the bug label Feb 4, 2025
@SirTyson SirTyson self-assigned this Feb 4, 2025
@SirTyson SirTyson mentioned this issue Feb 4, 2025
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 4, 2025
@graydon
Fixed inter ledger restore bug in p23 (#4639)
036c3fc 
# Description

Resolves #4638

Fixes a bug where an entry restored from the Hot Archive BucketList
could not be used by later transactions applied in the same ledger.

# Checklist
- [x] Reviewed the
[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)
document
- [x] Rebased on top of master (no merge commits)
- [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio
extension)
- [x] Compiles
- [x] Ran all tests
- [ ] If change impacts performance, include supporting evidence per the
[performance
document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SirTyson SirTyson

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed inter ledger restore bug in p23 SirTyson/stellar-core
1 participant
@SirTyson