Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stellar tx takes input as files and stdin #1822

Open
janewang opened this issue Jan 7, 2025 · 2 comments
Open

stellar tx takes input as files and stdin #1822

janewang opened this issue Jan 7, 2025 · 2 comments
Assignees

Comments

@janewang
Copy link
Contributor

janewang commented Jan 7, 2025

What would you like to see?

Current stellar tx only takes input as stdin. Like stellar xdr it should also accept files as inputs

Slack discussion here: https://stellarfoundation.slack.com/archives/C06KTGUULUF/p1736212430852659

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Jan 7, 2025
@sagpatil
Copy link
Contributor

sagpatil commented Jan 7, 2025

@leighmcculloch fyi

@janewang janewang moved this from Backlog (Not Ready) to Backlog (Ready for Design) in DevX Jan 7, 2025
@janewang janewang moved this from Backlog (Ready for Design) to Todo (Ready for Dev) in DevX Jan 7, 2025
@leighmcculloch
Copy link
Member

Recommend having a look at the stellar-xdr cli (that powers the stellar xdr command) for how it does files or stdin in its UI, to see if that same pattern would work for the stellar tx command:

https://github.com/stellar/rs-stellar-xdr/blob/28391e81229ad20a3d9ec56e1e1f382205335085/src/cli/encode.rs#L171-L183

The goal is not just to add the feature, but to maintain a UX parity between the stellar xdr command and the other commands that also work with xdr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo (Ready for Dev)
Development

No branches or pull requests

4 participants