Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit use of negative amounts #266

Open
sisuresh opened this issue Jul 5, 2023 · 0 comments
Open

Audit use of negative amounts #266

sisuresh opened this issue Jul 5, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@sisuresh
Copy link
Contributor

sisuresh commented Jul 5, 2023

Some contracts like timelock and the fuzzing example validate for negative values, and instead rely on the token implementation to fail. The problem is that the token interface accepts negative values, so some implementations can choose to implement custom logic to work with negative values. We should make sure none of our examples have a vulnerability due to this.

@sisuresh sisuresh added the bug Something isn't working label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants
@sisuresh and others