Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C ndarray API and refactor blas/ext/base/snansumpw #3353

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

Snehil-Shah
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray API for blas/ext/base/snansumpw.
  • refactors package to follow updated project conventions.
  • Updates stride handling where stride is equal to zero.
  • Adds test cases for NaN values.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 6, 2024
@Snehil-Shah Snehil-Shah added the Feature Issue or pull request for adding a new feature. label Dec 6, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 6, 2024

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/snansumpw $\color{green}457/457$
$\color{green}+100.00\%$
$\color{green}59/59$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}457/457$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@headlessNode headlessNode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Snehil-Shah Left an initial round of review. Thanks for working on this.

@headlessNode headlessNode added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 7, 2024
@headlessNode headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Dec 7, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @Snehil-Sha for your PR.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 7, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 7, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 7, 2024

PR Commit Message

feat: add C `ndarray` API and refactor `blas/ext/base/snansumpw`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3353

Reviewed-by: Muhammad Haris <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Snehil Shah <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit e3efb84 into stdlib-js:develop Dec 7, 2024
29 checks passed
@Snehil-Shah Snehil-Shah deleted the snansumpw-refactor branch December 17, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants