Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add array/base/broadcasted-ternary4d #3232

Merged
merged 10 commits into from
Nov 26, 2024
Merged

feat: add array/base/broadcasted-ternary4d #3232

merged 10 commits into from
Nov 26, 2024

Conversation

Vinit-Pandit
Copy link
Contributor

Resolves #3165 .

Description

What is the purpose of this pull request?

This pull request:

  • adding array/base/broadcasted-ternary4d

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Vinit-Pandit Vinit-Pandit changed the title feat: add array/base/broadcasted-ternary4d feat: add array/base/broadcasted-ternary4d Nov 23, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 23, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
array/base/broadcasted-ternary4d $\color{green}252/252$
$\color{green}+100.00\%$ 		$\color{green}12/12$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}252/252$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. labels Nov 24, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 25, 2024
@Vinit-Pandit @kgryte
Apply suggestions from code review
7a749df 
fix: fix spaces

Co-authored-by: Athan <[email protected]>
Signed-off-by: Vinit Pandit <[email protected]>
@Vinit-Pandit Vinit-Pandit requested a review from kgryte November 25, 2024 14:41
kgryte
kgryte approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this, @MeastroZI.

Quick note: please make sure you have properly configured your local development environment according to the project dev guide. I would have expected our Git hooks to catch various lint errors observed in the TypeScript test files. Before every push, linting should be automatically run. If that isn't happening, then you need to run make init.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 26, 2024
@kgryte kgryte merged commit c712a8e into stdlib-js:develop Nov 26, 2024
12 checks passed
@Vinit-Pandit Vinit-Pandit deleted the broadcasted-ternary4d branch November 27, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add array/base/broadcasted-ternary4d
3 participants
@Vinit-Pandit @stdlib-bot @kgryte