feat: add array/base/mskbinary4d

[AbhijitRaut04]

Resolves #3179 .

Description

What is the purpose of this pull request?

This pull request:

• implements the mskbinary4d package for masked binary operations in the array/base namespace.
• and provides a 4D equivalent of the mskbinary4d package for binary callbacks using a mask array.

Related Issues

Does this pull request have any related issues?

This pull request:

• resolves [RFC]: add array/base/mskbinary4d #3179

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[kgryte]

This is looking good. Thanks for working on this. Once the initial nitpicks have been resolved, I'll do a closer final review.

[kgryte]

One thing that needs to be resolved before further review is the failing unit tests.

[kgryte]

@AbhijitRaut04 One last thing, you'll want to make sure you are branching off of develop. Based on the commit history above, that does not appear to be the case. Your dev flow should be

$ git checkout develop
$ git pull upstream develop
$ git checkout -b mskbinary4d

Do work. Open a PR. Get it merged.

Then, to work on a new feature, repeat the above.

$ git checkout develop
$ git pull upstream develop
$ git checkout -b feat/new_feature

where upstream has been configured to be

$ git remote add upstream https://github.com/stdlib-js/stdlib.git

[AbhijitRaut04]

@AbhijitRaut04 One last thing, you'll want to make sure you are branching off of develop. Based on the commit history above, that does not appear to be the case. Your dev flow should be

$ git checkout develop
$ git pull upstream develop
$ git checkout -b mskbinary4d

Do work. Open a PR. Get it merged.

Then, to work on a new feature, repeat the above.

$ git checkout develop
$ git pull upstream develop
$ git checkout -b feat/new_feature

where upstream has been configured to be

$ git remote add upstream https://github.com/stdlib-js/stdlib.git

@kgryte I have now discarded the commits of develop branch which i have raised. Will it work ?

[kgryte]

I have now discarded the commits of develop branch which i have raised. Will it work ?

My comment was intended to apply to all future PRs. For the current PR, you should leave the Git history, as is. The current diff is fine.

[AbhijitRaut04]

I have now discarded the commits of develop branch which i have raised. Will it work ?

My comment was intended to apply to all future PRs. For the current PR, you should leave the Git history, as is. The current diff is fine.
I have raised a new pr for issue #3180 after running above commands but the history is not refining.

[kgryte]

I have raised a new pr for issue #3180 after running above commands but the history is not refining.

Likely because you have messed up your local develop commit history. I suggest holding off on any further PRs. Prioritize getting your current set of PRs merged. Once those PRs are merged, then you should delete your local fork and start over by cloning the repository and from then on follow the procedure outlined above.

[AbhijitRaut04]

I have raised a new pr for issue #3180 after running above commands but the history is not refining.

Likely because you have messed up your local develop commit history. I suggest holding off on any further PRs. Prioritize getting your current set of PRs merged. Once those PRs are merged, then you should delete your local fork and start over by cloning the repository and from then on follow the procedure outlined above.

Ok I will wait to for it. I have raised pr's for issues #3180 #3179 #1942 and #2106 please take a look to it. I am ready to contribute.

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
array/base/mskbinary4d	$\color{green}171/171$ $\color{green}+100.00\%$	$\color{green}11/11$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}171/171$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[AbhijitRaut04]

@kgryte I have applied the changes suggested. I kindly request you to review this PR.

[kgryte]

LGTM. Thanks, @AbhijitRaut04!