You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Encountered an error when attempting to remove the last character of a string. Issues arise when using @stdlib/string/remove-last because a visual character can be comprised of multiple code points.
We should evaluate whether to make the implementation Unicode aware.
Related Issues
Does this issue have any related issues?
None.
Questions
Any questions for reviewers?
No.
Other
Any other information relevant to this issue? This may include screenshots, references, stack traces, sample output, and/or implementation notes.
N/A
Demo
If relevant, provide a link to a live demo.
N/A
Reproduction
What steps are required to reproduce the unexpected output?
In order to reproduce this bug, do the following:
attempt to remove the last character when comprised of two Unicode code points.
Expected Results
What are the expected results?
The visual character to be removed, not just a single code point.
Actual Results
What are the actual results?
The last code point is removed, not the full character.
Environments
What environments are affected (e.g., Node v0.4.x, Chrome, IE 11)? If Node.js, include the npm version, operating system, and any other potentially relevant platform information.
The following environments are affected:
all
The text was updated successfully, but these errors were encountered:
Checklist
Description
Encountered an error when attempting to remove the last character of a string. Issues arise when using
@stdlib/string/remove-last
because a visual character can be comprised of multiple code points.We should evaluate whether to make the implementation Unicode aware.
Related Issues
None.
Questions
No.
Other
N/A
Demo
N/A
Reproduction
In order to reproduce this bug, do the following:
Expected Results
The visual character to be removed, not just a single code point.
Actual Results
The last code point is removed, not the full character.
Environments
The following environments are affected:
The text was updated successfully, but these errors were encountered: