Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: update math/base/special/atanh according to the FreeBSD implementation #2089

Open
3 tasks done
gunjjoshi opened this issue Mar 29, 2024 · 6 comments · May be fixed by #3128
Open
3 tasks done

[RFC]: update math/base/special/atanh according to the FreeBSD implementation #2089

gunjjoshi opened this issue Mar 29, 2024 · 6 comments · May be fixed by #3128
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@gunjjoshi
Copy link
Member

gunjjoshi commented Mar 29, 2024 •
edited
Loading

Description

This RFC proposes updating the C implementation for math/base/special/atanh, according to the FreeBSD implementation.

We need to convert the floating-point value to a word and then perform integer calculations, as given in the original FreeBSD implementation.

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Deepakchowdavarapu
Copy link

@gunjjoshi I would like to solve this issue

@gunjjoshi
Copy link
Member Author

@Deepakchowdavarapu Thanks for volunteering, go ahead!

@Deepakchowdavarapu Deepakchowdavarapu mentioned this issue Aug 5, 2024
Closed
1 task
@Deepakchowdavarapu
Copy link

Hi @gunjjoshi , I've updated the atanh implementation as described in issue #2089. Could you please review my work in PR #2746? Also, if possible, I'd appreciate it if you could assign this issue to me.
Thanks for your time and consideration!

@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. difficulty: 3 Likely to be challenging but manageable. Math Issue or pull request specific to math functionality. Accepted RFC feature request which has been accepted. priority: Normal Normal priority concern or feature request. C Issue involves or relates to C. labels Aug 5, 2024
@RiyaChy072
Copy link

@gunjjoshi Can i try to work on this issue? Is it open?

@gunjjoshi
Copy link
Member Author

gunjjoshi commented Nov 16, 2024 •
edited
Loading

@RiyaChy072 Yes, feel free to submit a PR for this.

This was referenced Nov 17, 2024
Closed
Open
@RiyaChy072
Copy link

@gunjjoshi Can you kindly check if it's done or not? And kindly let me know if i should add more changing files. Also accept my apology for committing the contributor's list. It was accidentally happened and don't know what to do with it, as an absolute beginner. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
4 participants
@kgryte @gunjjoshi @Deepakchowdavarapu @RiyaChy072