make install fails on Apple Silicon M1 darwin-arm64

[walterra]

Description

Encountered an error when running make install from the development setup instructions.

Related Issues

No response

Questions

No.

Demo

No response

Reproduction

Follow the development setup instructions and run make install.

Expected Results

make install should complete without error.

Actual Results

When running make install on Apple M1, I get the following error related to the electron dependency:

Downloading Electron...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     9    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
make: *** [/Users/<redacted>/deps/tmp/electron-v6.0.10-darwin-arm64.zip] Error 22

It looks like electron needs to be at least version 11 to support Apple Silicon/M1/darwin-arm64.

I did some local tests with updating the setup to version 12 and make install was able to complete.

Verifying download...
Success.

Extracting Electron...
Running tests...
v12.2.3

Success.

Version

develop branch

Environments

N/A

Browser Version

No response

Node.js / npm Version

No response

Platform

macos M1

Checklist

• Read and understood the Code of Conduct.
• Searched for existing issues and pull requests.

[kgryte]

@walterra Thanks for reporting this issue. Will try and push a fix later this evening.

[kgryte]

Should be resolved in d333681.

If you still encounter issues when installing repository dependencies, feel free to reopen this issue.