From 4bc5c7efda9452e0fb18a2cfe59bf89a4d180534 Mon Sep 17 00:00:00 2001 From: Gunj Joshi Date: Thu, 5 Dec 2024 01:33:55 +0530 Subject: [PATCH] refactor: use external constant in `math/base/special/tribonacci` PR-URL: https://github.com/stdlib-js/stdlib/pull/3324 Reviewed-by: Athan Reines --- .../@stdlib/math/base/special/tribonacci/lib/main.js | 8 ++------ .../math/base/special/tribonacci/manifest.json | 11 ++++++++--- .../@stdlib/math/base/special/tribonacci/src/main.c | 4 ++-- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/tribonacci/lib/main.js b/lib/node_modules/@stdlib/math/base/special/tribonacci/lib/main.js index 1934282ef2b5..ae42aa6fce29 100644 --- a/lib/node_modules/@stdlib/math/base/special/tribonacci/lib/main.js +++ b/lib/node_modules/@stdlib/math/base/special/tribonacci/lib/main.js @@ -22,14 +22,10 @@ var isnan = require( '@stdlib/math/base/assert/is-nan' ); var isInteger = require( '@stdlib/math/base/assert/is-integer' ); +var FLOAT64_MAX_SAFE_NTH_TRIBONACCI = require( '@stdlib/constants/float64/max-safe-nth-tribonacci' ); // eslint-disable-line id-length var TRIBONACCI = require( './tribonacci.json' ); -// VARIABLES // - -var MAX_TRIBONACCI = 63; - - // MAIN // /** @@ -83,7 +79,7 @@ function tribonacci( n ) { isnan( n ) || isInteger( n ) === false || n < 0 || - n > MAX_TRIBONACCI + n > FLOAT64_MAX_SAFE_NTH_TRIBONACCI ) { return NaN; } diff --git a/lib/node_modules/@stdlib/math/base/special/tribonacci/manifest.json b/lib/node_modules/@stdlib/math/base/special/tribonacci/manifest.json index 6bfc690068b2..04f64e637d30 100644 --- a/lib/node_modules/@stdlib/math/base/special/tribonacci/manifest.json +++ b/lib/node_modules/@stdlib/math/base/special/tribonacci/manifest.json @@ -36,7 +36,8 @@ "libraries": [], "libpath": [], "dependencies": [ - "@stdlib/math/base/napi/unary" + "@stdlib/math/base/napi/unary", + "@stdlib/constants/float64/max-safe-nth-tribonacci" ] }, { @@ -49,7 +50,9 @@ ], "libraries": [], "libpath": [], - "dependencies": [] + "dependencies": [ + "@stdlib/constants/float64/max-safe-nth-tribonacci" + ] }, { "task": "examples", @@ -61,7 +64,9 @@ ], "libraries": [], "libpath": [], - "dependencies": [] + "dependencies": [ + "@stdlib/constants/float64/max-safe-nth-tribonacci" + ] } ] } diff --git a/lib/node_modules/@stdlib/math/base/special/tribonacci/src/main.c b/lib/node_modules/@stdlib/math/base/special/tribonacci/src/main.c index 7c67d18b71d6..4c40ca64d130 100644 --- a/lib/node_modules/@stdlib/math/base/special/tribonacci/src/main.c +++ b/lib/node_modules/@stdlib/math/base/special/tribonacci/src/main.c @@ -17,8 +17,8 @@ */ #include "stdlib/math/base/special/tribonacci.h" +#include "stdlib/constants/float64/max_safe_nth_tribonacci.h" -static const int32_t STDLIB_CONSTANTS_FLOAT64_MAX_SAFE_NTH_TRIBONACCI = 63; // TODO: consider making a package similar to `@stdlib/constants/float64/max-safe-nth-fibonacci` static const int64_t tribonacci_value[ 64 ] = { 0, 0, @@ -96,7 +96,7 @@ static const int64_t tribonacci_value[ 64 ] = { * // returns 0 */ double stdlib_base_tribonacci( const int32_t n ) { - if ( n < 0 || n > STDLIB_CONSTANTS_FLOAT64_MAX_SAFE_NTH_TRIBONACCI ) { + if ( n < 0 || n > STDLIB_CONSTANT_FLOAT64_MAX_SAFE_NTH_TRIBONACCI ) { return 0.0 / 0.0; // NaN } return tribonacci_value[ n ];