Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for signTypedData_v4 #2062

Closed
flexsurfer opened this issue Oct 27, 2020 · 2 comments
Closed

Add support for signTypedData_v4 #2062

flexsurfer opened this issue Oct 27, 2020 · 2 comments

Comments

@flexsurfer
Copy link
Member

flexsurfer commented Oct 27, 2020 •
edited by 0xc1c4da
Loading

Problem

It's not possible to sign typed data with the latest spec (signTypedData_v4)

Implementation

https://docs.metamask.io/guide/signing-data.html#sign-typed-data-v4
@flexsurfer flexsurfer mentioned this issue Oct 27, 2020
Closed
@cammellos
Copy link
Contributor

I looked a bit into this, and I am a bit confused, I believe metamask implementation might not be according to specs.
We have our own implementation of signed type data, but we can use geth's.
That should be fairly easy, but not sure exactly now if I am right in saying that metamask is not according to specs.

MetaMask/eth-sig-util#107

@flexsurfer
Copy link
Member Author

#2182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cammellos @flexsurfer