Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miner should abort waiting for proposals #5705

Closed
kantai opened this issue Jan 15, 2025 · 1 comment
Closed

Miner should abort waiting for proposals #5705

kantai opened this issue Jan 15, 2025 · 1 comment
Assignees

Comments

@kantai
Copy link
Member

kantai commented Jan 15, 2025

The nakamoto miner should behave a little less strictly when it comes to waiting for proposals:

If the miner sees that they have 20% rejections, and have already waited, e.g., 2 minutes, they should consider their proposal rejected. We could probably come up with some smooth function over the range [0, 30] which defines how long the miner should be waiting. If they haven't received any rejections, then wait forever (as is the current behavior), and if they've received >30% rejections, then abort immediately (as is the current behavior). In between, we want to do something more heuristic.

My guess is that we want something squared:

10 - 10*(x/30)^2

Or just something stepped:

0-10% rejection: wait 10 minutes
10-20% rejection: wait 5 minutes
20-30% rejection: wait 2.5 minutes

@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Jan 15, 2025
@aldur aldur moved this from Status: 🆕 New to Status: 💻 In Progress in Stacks Core Eng Jan 15, 2025
@aldur aldur added this to the 3.1.0.0.4 milestone Jan 15, 2025
@aldur aldur modified the milestones: 3.1.0.0.4, 3.1.0.0.5 Jan 22, 2025
@aldur aldur moved this from Status: 💻 In Progress to Status: In Review in Stacks Core Eng Jan 28, 2025
@aldur aldur modified the milestones: 3.1.0.0.5, 3.1.0.0.6 Feb 4, 2025
@kantai
Copy link
Member Author

kantai commented Feb 4, 2025

Closed by #5731

@kantai kantai closed this as completed Feb 4, 2025
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Feb 4, 2025
@kantai kantai removed this from the 3.1.0.0.6 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Status: ✅ Done
Development

No branches or pull requests

3 participants