Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[signer] event parity should apply to all incoming signer messages #5613

Open
jferrant opened this issue Dec 23, 2024 · 1 comment
Open

[signer] event parity should apply to all incoming signer messages #5613

jferrant opened this issue Dec 23, 2024 · 1 comment
Assignees
Milestone

Comments

@jferrant
Copy link
Collaborator

Currently event parity is only applied to a block proposal. It should be applied to both SignerEvent::BlockValidationResponse(_) and Some(SignerEvent::MinerMessages(..)). The lack of proper reward cycle checks caused the chain to stall. See #5612

This will require changes to both the node and the signer.

As part of this ticket, remove the parity check within the hotfix handle_block_validate_* fns as it should be done in the outer call (also prevents double incrementing metrics when they shouldn't be)

@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Dec 23, 2024
@jcnelson jcnelson added this to the 3.1.0.0.3 milestone Jan 3, 2025
@jferrant
Copy link
Collaborator Author

jferrant commented Jan 8, 2025

Related to #5662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

2 participants