Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[signer] Track 429 block submission failures in the database and resubmit them following a block validation response #5440

Closed
jferrant opened this issue Nov 8, 2024 · 1 comment · Fixed by #5453
Closed

[signer] Track 429 block submission failures in the database and resubmit them following a block validation response #5440

jferrant opened this issue Nov 8, 2024 · 1 comment · Fixed by #5453
Assignees
@hstove
Labels
enhancement Iterations on existing features or infrastructure. locked performance-optimizations signer
Milestone
3.1.0.0.4

Comments

@jferrant
Copy link
Collaborator

jferrant commented Nov 8, 2024

Currently signers do not reattempt to submit block proposals to their nodes if they fail to do so due to a 429 (node already processing a block proposal).

It is possible that a miner sends two block proposals relatively close together. Especially at a tenure boundary. and it would be good to consider that new miners block proposal even if we are still processing the last one. Cause otherwise we may never respond to that newer proposal and be an unresponsive signer in regards to it.
@jferrant jferrant added enhancement Iterations on existing features or infrastructure. signer labels Nov 8, 2024
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Nov 8, 2024
@saralab saralab added this to the Nakamoto-3.0.x milestone Nov 11, 2024
@obycode obycode changed the title [signer] Track 429 block submission failures in the database and resubmit them following a block validaiton response [signer] Track 429 block submission failures in the database and resubmit them following a block validation response Nov 11, 2024
@hstove hstove mentioned this issue Nov 12, 2024
Merged
@hstove hstove linked a pull request Nov 12, 2024 that will close this issue
feat: prevent multiple block proposal evals #5453
Merged
@hstove hstove moved this from Status: 🆕 New to Status: 💻 In Progress in Stacks Core Eng Nov 14, 2024
@hstove hstove mentioned this issue Nov 14, 2024
Open
@hstove hstove modified the milestones: Nakamoto-3.0.x, 3.1.0.0.3 Dec 19, 2024
@hstove hstove moved this from Status: 💻 In Progress to Status: In Review in Stacks Core Eng Dec 19, 2024
@hstove hstove closed this as completed Jan 15, 2025
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Jan 15, 2025
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hstove hstove

Labels
enhancement Iterations on existing features or infrastructure. locked performance-optimizations signer
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
3.1.0.0.4
Development

Successfully merging a pull request may close this issue.

feat: prevent multiple block proposal evals stacks-network/stacks-core
4 participants
@saralab @hstove @jferrant @blockstack-devops