Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top Cowboys page shows top posts when time descriptor is added to the url #1890

Open
1 task done
ed-kung opened this issue Feb 9, 2025 · 2 comments
Open
1 task done
Labels

Comments

@ed-kung
Copy link

ed-kung commented Feb 9, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

If you go to https://stacker.news/top/cowboys/day, you'll see the top daily posts instead of top cowboys, but cowboy is still in the type selector.

Same behavior if you do https://stacker.news/top/cowboys/month, etc.

If you go to https://stacker.news/top/cowboys/anything, it seems to default to show top posts from forever.

Screenshots

Image

Steps To Reproduce

Expected behavior

If cowboys don't have metrics by time-period, then the expected behavior would be to redirect to https://stacker.news/top/cowboys or give a not found error

Logs

No response

Device information

No response

Additional context

No response

@ed-kung ed-kung added the bug label Feb 9, 2025
@ekzyis
Copy link
Member

ekzyis commented Feb 9, 2025

Thanks for the ticket! I agree with your expected behavior.

How did you discover this? Is there a way to get to this state via the frontend?

@ed-kung
Copy link
Author

ed-kung commented Feb 9, 2025

I was playing around with the url to see if the same pattern for top/posts/day would work with cowboys

I didn't access it from the front end and didn't see a way to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants