Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test framework to use exit codes rather than inspecting stderr #43

Open
Rewbert opened this issue Jul 9, 2021 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed not-urgent Use this labels for issues that are not urgent.

Comments

@Rewbert
Copy link
Collaborator

Rewbert commented Jul 9, 2021

The testing framework currently inspects stderr to figure out if running the c-code went alright, but we might want to use this stream for logging down the road. We should change the testing framework to use error codes instead and not rely on the stderr stream.

@Rewbert Rewbert added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed not-urgent Use this labels for issues that are not urgent. labels Jul 9, 2021
@Rewbert Rewbert mentioned this issue Jul 9, 2021
@j-hui
Copy link
Collaborator

j-hui commented Jul 9, 2021

We should use our own assertions (e.g., DEBUG_ASSERT) rather than relying on the C stdlib's assert macro---it gives us more control over what information to report, where to report it, and what to do afterwards.

j-hui added a commit that referenced this issue Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed not-urgent Use this labels for issues that are not urgent.
Projects
None yet
Development

No branches or pull requests

2 participants