Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of self-signed.badssl.com more robust #43708

Open
snicoll opened this issue Jan 7, 2025 · 0 comments
Open

Make use of self-signed.badssl.com more robust #43708

snicoll opened this issue Jan 7, 2025 · 0 comments
Labels
type: task A general task
Milestone
3.3.x

Comments

@snicoll
Copy link
Member

snicoll commented Jan 7, 2025

We're using https://self-signed.badssl.com to validate a scenario where SSL validation may be skipped locally. Changes to the site are affecting us (as right now where this URL started to return a 404 where it previously returned a 200).

We should update our infrastructure to use a local server that we control.
@snicoll snicoll added the type: task A general task label Jan 7, 2025
@snicoll snicoll added this to the 3.3.x milestone Jan 7, 2025
snicoll added a commit that referenced this issue Jan 7, 2025
@snicoll
Make skipSslValidation() test more robust
6290b75 
This commit updates the assertion of a test that relies on
https://self-signed.badssl.com to only fail if a SSLException is thrown.

This is a temporary measure until we run the test against a local
instance we control.

See gh-43708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
3.3.x
Development

No branches or pull requests
1 participant
@snicoll