Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review @ConditionalOnProperty with 'havingValue = "false"' and 'matchIfMissing = true' #43705

Closed
philwebb opened this issue Jan 6, 2025 · 1 comment
Closed

Review @ConditionalOnProperty with 'havingValue = "false"' and 'matchIfMissing = true' #43705

philwebb opened this issue Jan 6, 2025 · 1 comment

Comments

@philwebb
Copy link
Member

philwebb commented Jan 6, 2025

The following classes have @ConditionalOnProperty with havingValue = "false" and matchIfMissing = true. We should review if matchIfMissing = true is correct or not:

  • ActiveMQConnectionFactoryConfiguration
  • ActiveMQXAConnectionFactoryConfiguration
  • ArtemisConnectionFactoryConfiguration
  • ConnectionFactoryConfigurations
@philwebb philwebb added status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels Jan 6, 2025
@philwebb
Copy link
Member Author

philwebb commented Jan 8, 2025

These are actually fine.

@philwebb philwebb closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2025
@philwebb philwebb removed status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philwebb