Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for URLConnectionSender #43048

Open
mhalbritter opened this issue Nov 6, 2024 · 0 comments
Open

Remove support for URLConnectionSender #43048

mhalbritter opened this issue Nov 6, 2024 · 0 comments
Labels
type: enhancement A general enhancement
Milestone

Comments

@mhalbritter
Copy link
Contributor

In #42589, we make ZipkinHttpClientSender the default sender. The conditions for that bean are:

@ConditionalOnClass(HttpClient.class)
@ConditionalOnMissingBean(BytesMessageSender.class)

that means on every JDK which has HttpClient in it (which should be most of them, unless you built a custom one with jlink), ZipkinHttpClientSender will be used.

Given that, I think we can remove URLConnectionSender, which needs the zipkin-sender-urlconnection dependency on the classpath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant