Honor @NestedTestConfiguration semantic in BatchTestContextCustomizerFactory
#4739
+92
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scordio
force-pushed
the
gh-4738-spring-batch-test
branch
from
28dcfe4 to
bd2b2a9
Compare
scordio
changed the title
spring.factories with @ContextCustomizerFactoriesContextCustomizerFactory for @SpringBatchTest
|
Having only viewed this on my phone, I can’t say for sure, but… my hunch is that the solution is to replace Give that a try and let me know how it goes… 😉 |
|
Thanks, will do! |
scordio
force-pushed
the
gh-4738-spring-batch-test
branch
from
bd2b2a9 to
b188e4b
Compare
scordio
changed the title
ContextCustomizerFactory for @SpringBatchTest@NestedTestConfiguration semantic in BatchTestContextCustomizerFactory
|
Thanks a lot, @sbrannen! With your input, the fix is now simpler and doesn't require the removal of |
scordio
force-pushed
the
gh-4738-spring-batch-test
branch
2 times, most recently
from
2f5f3e8 to
bcb8fd8
Compare
scordio
force-pushed
the
gh-4738-spring-batch-test
branch
from
bcb8fd8 to
690c683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
BatchTestContextCustomizerFactoryonly looked for@SpringBatchTeston the given test class as a marker annotation. While this works fine for top-level classes, it doesn't work correctly with JUnit@Nestedclasses, resulting in a distinctApplicationContextfor the nested class as a side effect.With this change, the factory no longer uses
AnnotatedElementUtils.hasAnnotationand favors insteadTestContextAnnotationUtils.hasAnnotation, which honors the@NestedTestConfigurationsemantic.Fixes #4738.