[Core] Implementations of FunctionCallback.Builder cannot instantiate FunctionInvokingFunctionCallback and MethodInvokingFunctionCallback
#2032
Comments
ThomasVitale
added a commit
to ThomasVitale/spring-ai
that referenced
this issue
Jan 3, 2025
* Make constructor in MethodInvokingFunctionCallback public. * Make constructor in FunctionInvokingFunctionCallback public. * Make JSON Schema Generation strategy in MethodInvokingFunctionCallback more customizable. Fixes spring-projectsgh-2032 Signed-off-by: Thomas Vitale <[email protected]>
This was referenced Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
The
FunctionInvokingFunctionCallbackandMethodInvokingFunctionCallbackclasses have package-scoped constructors, meaning that it's not possible to instantiate them outside their package. As a consequence, the only way to get instances is via Reflection or via theDefaultFunctionCallbackBuilder. Among the other things, this issue impacts custom implementations ofFunctionCallback.Builder.Environment
Spring AI: 1.0.0-SNAPSHOT
Java: 23
Expected behavior
The
FunctionInvokingFunctionCallbackandMethodInvokingFunctionCallbackclasses can be instantiated outside their package.Minimal Complete Reproducible example
See the consequence of this issue here, where Reflection had to be used to instantiate
FunctionInvokingFunctionCallback(example) andMethodInvokingFunctionCallback(example).The text was updated successfully, but these errors were encountered: