Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Similarity search threshold can be a float instead of a double #1996

Open
markpollack opened this issue Dec 21, 2024 · 1 comment
Open

Similarity search threshold can be a float instead of a double #1996

markpollack opened this issue Dec 21, 2024 · 1 comment

Comments

@markpollack
Copy link
Member

public Builder similarityThreshold(double threshold)

results in having to pass in a d to the method that is inconvenient. There isn't a need for such fine grained values of the threshold.

SearchRequest.builder().similarityThreshold(0.99d).topK(6).build()

@bruno-oliveira
Copy link
Contributor

@markpollack then on the caller sites we need to update it to use the f qualifier right? The advantage is that the float takes less space than the double for the same effect right?

I haven’t investigated yet but then at the DB schema level the value will be automatically converted right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants