Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make methods in VaultConfigDataLoader and VaultConfigDataLocationResolver more accessible (protected/public) #741

Open
yidongnan opened this issue Jan 21, 2025 · 1 comment

Comments

@yidongnan
Copy link

yidongnan commented Jan 21, 2025

When extending VaultConfigDataLoader and VaultConfigDataLocationResolver for customized development, I encountered some obstacles. Certain methods in these classes are set to private, making it impossible to reuse existing logic or override specific behaviors when inheriting these classes.

To enable more flexible extensibility, I suggest changing the access modifiers of these methods from private to protected or public.

If this suggestion is accepted, I am willing to create a merge request for this change.

@mp911de
Copy link
Member

mp911de commented Jan 21, 2025

Taking a step back from the proposed changes, care to elaborate what kind of customizations you're looking for? What are you trying to achieve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants