-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash after exiting - when using HW wallet - on MacOS Monterrey #7738
Comments
I am able to replicate the crash on macOS. Happens with all hardware devices (ledger nano s, nano x, trezor one, trezor t and keepkey). Crash does not happen on Linux and Windows. |
@gruve-p are you also using macos 12 as OP? or does it also happen on older versions? |
Electrum Version: 4.2.0 and MacOS Version: 12.2.1 -> crash after exiting hardware wallet Electrum Version: 4.1.5 and MacOS Version: 12.2.1 -> NO crash after exiting hardware wallet |
Could you test these scenarios:
|
crashes
crashes |
Also having this crash. |
Looking at the crash stacktrace and this commit , it seems that hidapi_exit() could be the culprit here. Using latest hidapi 0.11.2 might fix this issue. |
I reran freeze_packages 184e122 which pulls in 0.11.2 |
Could someone who can reproduce try to build from master and test with that? Or alternatively, you can test with the binary built by the CI: |
I'm getting the same on Monterrey and Mojave 10.14.6 |
Would be great if someone that can reproduce tested and reported if this is fixed on master now. :) |
Building from source (master on MacOS Version: 12.4) -> crash after exiting hardware wallet |
I'll add that a crash happens even if a HW wallet isn't physically connected, it only needs to be configured in the wallet. |
Can confirm this issue on Macbook Pro with OSX 12.3.1 (NOT M1) and latest Electrum 4.2.1. Can also confirm that crash is only happening on exit if you had a wallet connected to a hardware wallet open. (doesnt need to be physically connected) |
Happens to me too on MacOS 12.4. I imported a .json from my MK4 Coldcard. |
Ok, I can reproduce. The immediate cause seems to be a regression in recent hidapi versions. |
Electrum Version: 4.2.0
MacOS Version: 12.2.1
Crash after exiting the app, only when using Hardware wallet prior. Although, just opening the first wallet screen seems to be enough, where it says something to the effect of "I see your HW wallet, confirm you want to open it". Exiting there will generate the crash also.
Error report below:
The text was updated successfully, but these errors were encountered: