Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint to avoid putting newlines in links or variables #2872

Open
tabatkins opened this issue Jun 13, 2024 · 5 comments
Open

Lint to avoid putting newlines in links or variables #2872

tabatkins opened this issue Jun 13, 2024 · 5 comments

Comments

@tabatkins
Copy link
Collaborator

Request from a fellow Chromie: a lint that warns if you have broken a link or variable across lines, as that makes it harder to search for terms in the source later.

I should be able to do this now, by walking the document. I can possibly do it better with the parser rewrite, but I don't think I need to wait for that; it'll just give me better line numbers in the error.

@domfarolino
Copy link

I think I disagree with this change. The specs I work on generally follow the HTML Standard style guide, which allows for line breaks in between words in a dfn or link, or even within tags associated wtih those dfns or links. All of those specs will I guess just be broken now if they treat warnings as fatal? That seems bad and backwards incompatible.

@tabatkins
Copy link
Collaborator Author

Lints are always optional, and this would be default-off, like most of the lints are.

@domenic
Copy link
Collaborator

domenic commented Jan 22, 2025

I'd be interested in this but it would be a prerequisite to be able to toggle on or off specific lints, since we'd want this one off but other lints on for some specs. (And both this and other lints on for other specs.)

@tabatkins
Copy link
Collaborator Author

You can already do that by specifying the Complain About metadata. Or were you talking about something else?

@domenic
Copy link
Collaborator

domenic commented Jan 22, 2025

I guess it might be a documentation problem, but I didn't realize "lints" were the same as "Complain About".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants