From ee3d8e3eac8d2256546ec0b9c8becd036962eb4b Mon Sep 17 00:00:00 2001
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
Date: Fri, 29 Mar 2013 10:31:14 -0300
Subject: [PATCH] utils/check_patch.py: Speed and memory usage improvements

Turns out we had a bug in the code that verified whether
a file was tracked by git. With the bug fixed, a lot less
files will be scanned. Moreover, expand the list of
blacklisted extensions and paths, making it faster to
check the tree, even if you have logs in it.

Also, instead of creating multiple file checker
objects, that will be stored in memory, refactor
the existing one to process several files and
use it. This greatly saves memory.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
---
 utils/check_patch.py | 53 ++++++++++++++++++++++++--------------------
 1 file changed, 29 insertions(+), 24 deletions(-)

diff --git a/utils/check_patch.py b/utils/check_patch.py
index f0ded45796..c8dc304187 100755
--- a/utils/check_patch.py
+++ b/utils/check_patch.py
@@ -255,25 +255,13 @@ def get_modified_files(self):
 
 
     def is_file_tracked(self, fl):
-        stdout = None
         try:
-            cmdresult = utils.run("git status --porcelain %s" % fl,
-                                  verbose=False)
-            stdout = cmdresult.stdout
+            utils.run("git ls-files %s --error-unmatch" % fl,
+                      verbose=False)
+            return True
         except error.CmdError:
             return False
 
-        if stdout is not None:
-            if stdout:
-                if stdout.startswith("??"):
-                    return False
-                else:
-                    return True
-            else:
-                return True
-        else:
-            return False
-
 
     def add_untracked_file(self, fl):
         """
@@ -332,7 +320,7 @@ class FileChecker(object):
     Picks up a given file and performs various checks, looking after problems
     and eventually suggesting solutions.
     """
-    def __init__(self, path, vcs=None, confirm=False):
+    def __init__(self, path=None, vcs=None, confirm=False):
         """
         Class constructor, sets the path attribute.
 
@@ -341,6 +329,10 @@ def __init__(self, path, vcs=None, confirm=False):
         @param confirm: Whether to answer yes to all questions asked without
                 prompting the user.
         """
+        if path is not None:
+            self.set_path(path=path, vcs=vcs, confirm=confirm)
+
+    def set_path(self, path, vcs=None, confirm=False):
         self.path = path
         self.vcs = vcs
         self.confirm = confirm
@@ -691,7 +683,9 @@ def check(self):
         vcs = None
 
     logging_manager.configure_logging(CheckPatchLoggingConfig(), verbose=debug)
-    ignore_list = ['common.py', ".svn", ".git", '.pyc', ".orig", ".rej", ".bak"]
+    extension_blacklist = ["common.py", ".java", ".html", ".png", ".css",
+                           ".xml", ".pyc", ".orig", ".rej", ".bak", ".so"]
+    dir_blacklist = [".svn", ".git", "logs", "virt", "site-packages", "ExternalSource"]
 
     if full_check:
         failed_paths = []
@@ -708,22 +702,33 @@ def check(self):
                               "the google protocol buffer compiler, refer to "
                               "%s for more info", proto_cmd, doc)
                 sys.exit(1)
+
+        file_checker = FileChecker()
         for root, dirs, files in os.walk("."):
-            for fl in files:
+            dirs[:] = [d for d in dirs if d not in dir_blacklist]
+
+            t_files = []
+            for f in files:
+                add = True
+                for extension in extension_blacklist:
+                    if f.endswith(extension):
+                        add = False
+                if add:
+                    t_files.append(f)
+            files = t_files
+
+            for f in files:
                 check = True
-                path = os.path.join(root, fl)
-                for pattern in ignore_list:
-                    if re.search(pattern, path):
-                        check = False
+                path = os.path.join(root, f)
                 if check:
                     if vcs is not None:
                         if not vcs.is_file_tracked(fl=path):
                             check = False
                 if check:
-                    file_checker = FileChecker(path=path, vcs=vcs,
-                                               confirm=confirm)
+                    file_checker.set_path(path=path, vcs=vcs, confirm=confirm)
                     if not file_checker.report(skip_unittest=True):
                         failed_paths.append(path)
+
         if failed_paths:
             logging.error("Full tree check found files with problems:")
             for fp in failed_paths: