Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bug Introduced in H6 for 1.18.1 and 1.18.2. #6731

Closed
mysticdrew opened this issue Mar 31, 2022 · 5 comments
Closed

[BUG] Bug Introduced in H6 for 1.18.1 and 1.18.2. #6731

mysticdrew opened this issue Mar 31, 2022 · 5 comments

Comments

@mysticdrew
Copy link

Description of Issue

Getting a ton of 1282 OpenGL Errors on the first RenderSystem, no matter what order they are in when rendering journeymap's waypoint icon in the world. I have tried switching up the order to no avail.
Several issues here. This is how I set up the waypoint icon.
While I do not need the rendersystem calls here, if I remove them optifine makes all minecraft text blurry and then I get 1282 errors on depthTest call later down the line. Moving the vertexbuilder logic to after the RenderSystem calls makes text blurry.

VertexConsumer vertexBuilder = buffers.getBuffer(WaypointRenderTypes.getIcon(waypoint.getTextureResource())); RenderSystem.setShaderTexture(0, waypoint.getTexture().getId()); RenderSystem.setShader(GameRenderer::getPositionColorTexShader); RenderSystem.bindTexture(waypoint.getTexture().getId()); RenderSystem.activeTexture(33984);

This was not an issue and I cannot replicate this issue in H5.

Steps to Reproduce

make a bunch of waypoints in journeymap, press Z a bunch to make them appear and disappear is the fastest way to make it happen.

OptiFine Version

H6 and H7 preview builds for 1.18.1 1.18.2

Installation Method

Put it in mods folder

Fabric/Forge Version

Recommended forge versions for every optifine version I tested.

Other Installed Mods

Journemap

Log Files/Crash Reports

I added a ton of extra logging when a GL error occurs, you can see in the log
latest.log

@mysticdrew
Copy link
Author

mysticdrew commented Apr 1, 2022

@sp614x the logs I provided for you are from a custom build of Journeymap 5.8.1. I can also supply the custom build and/or our waypoint rendering class with you privately if you want.

So it seems just about any RenderSystem call is breaking at a random time on the forge RenderLevelLastEvent.
We construct the beam very similar to the vanilla BeaconRenderer, then we draw the name tag (if visible). Which when the black box around the nametag is drawn, sometimes gets a 1282 error on disableDepthTest.

After the name tag is drawn we draw the icon(if visible). Setting up the icon texture is the code provided above, this is where most of the error occur.

When the OpenGL Errors start, game textures go all crazy. Mob skins change to another mob, sometimes in the sky a random texture will display.

Also, I could not replicate this issue in H5 for 1.18.1 but I did have a user say that they could replicate it.

I also have a little extra OpenGL logging that logs which RenderSystem call is made when an error occurs. To enable this, in Journeymap, press J to open the fullscreen map, press O to open the options. Expand Advanced and check the GL Error check box. Restart minecraft, now when a GL error occurs with journeymap it will add say which exact RenderSystem, GLxC, or GlStateManager method was called when the error occurred.

@gregs007
Copy link

Seeing this issue as well. As soon as I remove optifine from mod folder issue doesn't happen anymore.
TeamJM/journeymap#412

Switched to fabric/lithium/sodium, etc for now, but would love to get back to Forge/OF as I just love it love it love it. Can't live without my journeymap beacons/waypoints tho since I'm old and get easily lost!!!

Love the work you all do. Thank you so much!

@endarz
Copy link

endarz commented May 10, 2022

I am having the exact same issue; I had the notion that resource packs contributed to the issue, but it seems that this bug persists, resource packs or not. This bug has occurred silently most of the time, but Optifine has and will throw a "generic error" message up from time to time.

Running Optifine HD U H6 on 1.18.1 in addition to JourneyMap 5.8.1.

@wolvyreen
Copy link

Having the exact same issue. Running JourneyMap latest and optifine 1.18.2 H7

The moment I interact with waypoints I start getting opengl error 1282 and it screws up my textures

@mysticdrew
Copy link
Author

These issues are resolved as of Journeymap 5.9.0 for 1.18.2 and 1.19.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants