-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Support more Webhook Actions #121
Comments
Based on https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=edited#pull_request, I would suggest the following additional
|
Not convinced the above list includes just new pushes to an existing Open PR... |
@bhamail - we had an issue on sonatype-nexus-community/sonatype-platform-browser-extension#136 where a force-push was done to fix commit signing - but this doesn't seem to have triggered a PR re-review by Paul Botsco ? Commit in question: sonatype-nexus-community/sonatype-platform-browser-extension@c8f5ff4 |
Yum. "Force" doesn't surprise me that it exposes edge cases. Would likely need to recreate this situation and "see what happens" to be sure we cover it. How did you work around the issue in that PR? |
I could find no way to work around it in that PR (without someone adding a new pointless commit). |
There are situations (sonatype-nexus-community/sonatype-platform-reference#12) where PR was created before Paul Bostco 2.0 was deployed.
Given we only listen for Webhooks where the
payload.Action
is one ofopened
,reopened
orsynchronize
(see line), we may miss getting Paul Botsco involved in some PRs.FYI @bhamail
The text was updated successfully, but these errors were encountered: