Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically inform the user on internal node error #251

Open
nemanja-boric-sociomantic opened this issue Jan 19, 2018 · 1 comment
Open

Comments

@nemanja-boric-sociomantic
Copy link
Contributor

nemanja-boric-sociomantic commented Jan 19, 2018

As discussed in #213 and #214, it is proposed to make sure node request handlers catch all exceptions and notify the client that there was an error. (i.e. request handlers should never throw.)

This can be implemented on the swarm level in the following way:

  • On the node side, catch the exceptions and send the message to the client with the different MessageType - so that the client doesn't need to be always registered for receiving error messages. However, as Handling of I/O exceptions in node request handlers #216 states, we shouldn't catch IOErrorin the RequestOnConn's fiber handler method, since the client will anyway be notified by the connection dropping.

  • On the client side, it's an open question how this message will be handled, since the notifiers are handled by the request, not by the connection handler in swarm. One possibility would be just to resume the request fiber with an exception, but that requires try/catch behaviour on the client side.

@gavin-norman-sociomantic

Moved to future. It sounds like this would be difficult to implement, and might require a new protocol version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants