-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt tests to use batch suspendable request core #193
Labels
Comments
This is non-essential. I'd prefer to release v4.5.0 and address this in the next milestone. |
I've got half way through converting the test GetAll request to use the current batch request core. It's not easy, though, and I get the feeling it'll take quite some time to get it working properly. I'd suggest that we instead move this issue to v4.7.0, and do it based on the new framework in #243. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Adapting the swarm neo test to work with two nodes, as part of #192, the suspend GetAll test hangs.
This appears to be due to a bug in
SuspendableRequestCore
. As debugging such code is pretty laborious, and it's essentially deprecated, I won't dig into it. Instead, we should adapt the tests to use the newer batch suspendable core.The text was updated successfully, but these errors were encountered: