Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damage rolls with {kh} or {dl} aren't correctly max-critted #11

Open
mvanduijvenvoorde opened this issue Nov 23, 2020 · 0 comments
Open

Comments

@mvanduijvenvoorde
Copy link

When rolling a damage roll from an item, for example 3d6dl (drop lowest), it doesn't have the right outcome. For example, I get 3d6dl + mod + 18, but it should be 3d6dl + mod + 12. Any idea what is going wrong?

Also the rollDamage code has been changed in recent Foundry versions and is now different than the override used in Max-Crit module. I think this may cause issues at the moment, or in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant