Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redux-immutable #56

Closed
dkniffin opened this issue Oct 13, 2017 · 3 comments
Closed

redux-immutable #56

dkniffin opened this issue Oct 13, 2017 · 3 comments

Comments

@dkniffin
Copy link
Contributor

dkniffin commented Oct 13, 2017

We should add immutable and redux-immutable to package.json, and we should change the top-level reducer to use that version of combineReducers

@leeallen337
Copy link
Contributor

Hm. Should we include ImmutableJS into the boilerplate? I think it was left out to make the boilerplate less opinionated but we include it in all our projects anyways so it would take less time to spin everything up. What do you think?

@dkniffin
Copy link
Contributor Author

dkniffin commented Feb 1, 2018

I think we should just include it. For a while, we were debating whether to use immutable everywhere or not, but I think at this point the decision has been made

@leeallen337
Copy link
Contributor

Good points 👍

I also spoke with @keeganbrown on Slack about Immutable and he agreed about including it in the boilerplate. I'm going to close this and include a task for including ImmutableJS in #64

Thanks @dkniffin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants