Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Steps for the Authentication Module #50

Open
jahammo2 opened this issue May 1, 2017 · 1 comment
Open

Next Steps for the Authentication Module #50

jahammo2 opened this issue May 1, 2017 · 1 comment

Comments

@jahammo2
Copy link
Contributor

jahammo2 commented May 1, 2017

What’s in Code Review:

Add register component

What still needs to be done:

  1. An error handling service.
  2. Write a readme. If someone else besides me gets around to this, let me know because I have a list of things to include.
  3. Fix the confirmation link (that you get from registering). Right now, the confirmation link can be used as many times as we want. It should only be able to be used once. Not sure if this is a backend or frontend problem.
  4. Change UPDATE_TOKEN_INFO in reducer to set more data. It’s only setting the tokenInfo but should be setting name and other things.
@dkniffin
Copy link
Contributor

dkniffin commented May 12, 2017

We're starting to implement this on Stilio. I've had a few of the ideas you mention above, and I'm sure I'll have more. Here's a few more for the list:

  • Make the auth endpoint configurable. Right now, you're stuck with /auth/..., but we've got it at /users/...
  • Update code to support react router v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants