Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize response JSON to always use full messages #89

Open
dacur opened this issue Mar 12, 2018 · 0 comments
Open

Standardize response JSON to always use full messages #89

dacur opened this issue Mar 12, 2018 · 0 comments
Labels
New Rails Config New functionality to be added to the generated Rails app

Comments

@dacur
Copy link
Contributor

dacur commented Mar 12, 2018

See this PR: https://github.com/smashingboxes/roamd-api/pull/35

NOTE: @dkniffin would like to be able to account for errors added to base, and I agree. As it stands, the code in the PR would return errors.add(:base, "User must have a name") as "Base user must have a name", which is not ideal.
@dkniffin dkniffin added the New Rails Config New functionality to be added to the generated Rails app label Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
New Rails Config New functionality to be added to the generated Rails app
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkniffin @dacur