Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-API builds are still getting SmashingDocs config. #112

Open
woolsox opened this issue Jun 7, 2018 · 2 comments
Open

Non-API builds are still getting SmashingDocs config. #112

woolsox opened this issue Jun 7, 2018 · 2 comments
Labels
Minor Bug Boxcar generates a working Rails app, but there is some flaw in the process

Comments

@woolsox
Copy link
Contributor

woolsox commented Jun 7, 2018

When spinning up a new app - we get the Is this an API only app? (y/N) prompt. In the case of answering N we still end up with spec_helper.rb config which has SmashingDoc references in it:

config.after(:each, type: :controller) do
SmashingDocs.run!(request, response, true)
end

This will cause rspec to throw a error: NameError: uninitialized constant SmashingDocs

@woolsox woolsox added the Minor Bug Boxcar generates a working Rails app, but there is some flaw in the process label Jun 7, 2018
@dkniffin
Copy link
Contributor

dkniffin commented Jun 7, 2018

@TylerRockwell Is this expected? I can't remember if SmashingDocs is useful against rails-view apps or not.

@TylerRockwell
Copy link
Contributor

@dkniffin It looks like SmashingDocs isn't being installed, for any type of app. Some of the config is added via this line, but I don't see the gem getting added anywhere.

And no, I don't think SmashingDocs is useful for a full stack app. Not unless it also has some API endpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Bug Boxcar generates a working Rails app, but there is some flaw in the process
Projects
None yet
Development

No branches or pull requests

3 participants