-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type-safe client: custom factory / supplier? #2262
Comments
Maybe what I wrote does not make sense I continue my investigation on how I can influence the query generation of the typesafe client |
The logic seems to be in |
So what exactly do you need to customize about the inline fragment? |
I have opened a PR to discuss my precise problem and requested change: If you know how I can try this change in my quarkus-app and/or in my standalone java app (executed using Jbang) I would be really interested. |
@jmartisk how realistic is for me to build a custom What I have is that if I build locally Client model version: And this implementation:
Containing my improvement discussed in #2264 So instead of using a But then to have this running in Quarkus? What should I do? I already tried some crazy things in the past to force quarkus to use a newer smallrye-graphql` version: As a work-around is there a way to tell Quarkus to not use the build-steps and do everything at runtime? My only other idea to have this fixed ASAP is to abandon the type-safe client and to transform it into a dynamic client where I would control the query. |
You can simply build a custom snapshot of smallrye-graphql and then, in the application's pom, declare |
If it doesn't work, you can checkout the quarkus |
Thank you for those input. I will give it a try |
I think this is a maven thing. My release (the maven release process failed somewhere but the client jars were published and I could upload them to our company maven repo) is based on this tag: With Gradle I did this: //upgrade 'smallrye-graphql-*' projects.
configurations.all {
resolutionStrategy.eachDependency { DependencyResolveDetails details ->
if (details.requested.group == 'io.smallrye' && details.requested.name.startsWith('smallrye-graphql') && details.requested.version == '2.12.1') {
details.useTarget group: 'patched.unblu.io.smallrye', name: details.requested.name, version: '2.12.2-unblu-2'
details.because 'To get the fix of https://github.com/smallrye/smallrye-graphql/pull/2264'
}
}
} And as far as I can tell the jars are correctly replaced by gradle. |
Thank you very much for your help, I think we can close this issue that was more a discussion. |
I am still working with the client and the query defined here #2224 (comment)
I would like to test a modification in
InlineFragmentImpl
and I was wondering if I can do this from the outside (from my Java main or Quarkus app)I have seen the part that creates the GraphQL query seems to be based on the concept of Factory / Supplier:
smallrye-graphql/client/api/src/main/java/io/smallrye/graphql/client/core/factory/InlineFragmentFactory.java
Lines 7 to 8 in 7a7a3ab
But I couldn't find if I can register my own supplier or not.
The text was updated successfully, but these errors were encountered: