Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shop more modular #626

Open
bummzack opened this issue Jan 29, 2018 · 2 comments
Open

Make shop more modular #626

bummzack opened this issue Jan 29, 2018 · 2 comments

Comments

@bummzack
Copy link
Collaborator

There are several components in the core that don't really belong to a "core". The problem is, that it's currently really hard to find anybody that maintains modules, but to improve overall quality of shop, I suggest to strip down the codebase by quite a bit.

The following features could be moved to separate modules:

  • Dashboard support (currently core contains some classes that build upon the dashboard module)
  • Shop-Reports
  • OpenGraph support (core contains some methods to work with the opengraph module). These aren't in a good state though
  • Variations (these were explicitly built with modularity in mind, but yet they are still in core)
  • Zones & Zones Modeladmin (I can't find any place where this is being used in core. Should probably be part of the shipping module?)

Did I miss anything? Opinions?

@wilr
Copy link
Contributor

wilr commented Jan 29, 2018

@bummzack Variations, Open Graph, Dashboard makes a large amount of sense. Still a few modifers lying around for shipping in core - I'd imagine these should all be brought out to the shipping module as well.

@wernerkrauss
Copy link
Contributor

Also e.g. an OrderItem should have the possibility to define its EditForm.

I built a CustomProductType where you can register for something (e.g. the Name and Address is bound to that CustomOrderItem), how can I easily add functionality to correct a typo in your name?

Same would be if we have a GiftCardItem where you can set a Price or some other special parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants