Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in ColoredProductExtension.php #13

Open
sparkcom opened this issue Nov 14, 2020 · 1 comment
Open

Images in ColoredProductExtension.php #13

sparkcom opened this issue Nov 14, 2020 · 1 comment

Comments

@sparkcom
Copy link
Contributor

Hello,

I propose to change 'Images' to 'ColorImages' to make it more specific.

That's because when people extend Product.php to have more product images, more often, people may just use 'Images' for Product Images. And if that happens, there will be a conflict between this extension and an extension to have more product images.

@wilr
Copy link
Contributor

wilr commented Nov 19, 2020

@sparkcom Makes sense, would also be an issue if you added Images to the base Page type which could be common. If you submit a PR I'll tag a new major release and document the change. I think we need to include a migration script for people so that it automatically comes across.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants