Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect "Fixes" lines in commit messages, close mentioned issue #30

Open
3 tasks
dmitshur opened this issue Sep 14, 2019 · 0 comments
Open
3 tasks

detect "Fixes" lines in commit messages, close mentioned issue #30

dmitshur opened this issue Sep 14, 2019 · 0 comments
Labels
enhancement

Comments

@dmitshur
Copy link
Member

dmitshur commented Sep 14, 2019 •
edited
Loading

When someone merges a commit to the main branch of a repository on https://dmitri.shuralyov.com, its commit message should be scanned for any "Fixes" lines, and said issues should be closed. (See dmitri.shuralyov.com/website/gido/...@5bb3cef2 for a recent example where this would've been helpful.)

This requires:

  • coming up with a well-defined syntax for the "Fixes" lines
    • it needs to be compatible with indieweb URLs
  • implementing code to parse commit message and detecting "Fixes" lines
  • performing an issue service API call to close said issue

Once implemented, similar functionality can be used to help resolve golang/go#29599.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmitshur