New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract & Rewrite MessageStruct #3

Open

sheldonth opened this issue Oct 26, 2015 · 1 comment

Owner

sheldonth commented Oct 26, 2015

MessageStruct needs to be class that does some memory management and pointer ownership.

Safely delete the new messagestruct class after the javascript method has been kicked off that moves the data

Owner Author

sheldonth commented Sep 27, 2016

MessageStruct sucks because:

Struct needn't be part of the name of a C struct used in C++
It should be a class that does some smart allocation and deletion, and probably manages a smart pointer of it's own to the serialized message data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment