[Bug] Failed to call updater.get_update_list(): Missing dependencies for SOCKS support.

[sdsvkz]

Before Reporting

• I found no existing issues matching my bug
• My issue is not caused by a theme
• My issue is not caused by a plugin

Describe the Bug

Python detected my socks5 proxy (set through ALL_PROXY environment variable), but Millennium's python distribution does not have PySocks installed for socks support.
This cause "Updates" tab fails to retrieving update list in my case. It shows nothing under "Push Notifications" section.

NOTE: I installed Millennium manually by following the official guide.

Expected Behavior

Show list of updates.

Steps To Reproduce

1. Set socks proxy through ALL_PROXY environment variable.
2. Open Steam.
3. Go to Settings -> Updates.

Operating System

Windows

Anything else?

[30:50.740] INFO [email protected] is up to date.
[30:50.745] INFO Ports: { FTP: 8777, IPC: 8803 }
[30:50.746] INFO Plugins: { core: Enabled }
[30:50.747] INFO Verifying Python environment...
[30:50.824] INFO Starting plugin backends...
[30:50.824] INFO Opting to use '8080' for SteamDBG port
[30:50.824] INFO Created thread 1930017404 for plugin 'pipx'
[30:50.827] INFO Starting frontend socket...
[30:50.827] INFO Startup took 2473 ms
[30:50.847] INFO Redirecting stdout/stderr for plugin 'pipx'
[30:50.847] INFO Invoking plugin main callback for 'pipx'
[30:50.848] INFO Started preloader module
[30:51.050] PIPX Starting Package Manager...
[30:51.068] PIPX checking for packages on Windows
[30:51.097] PIPX All required packages are satisfied.
[30:51.097] PIPX Finished in 45.24 ms
[30:51.097] INFO Preloader finished...
[30:51.097] INFO Notified plugin [pipx] to shut down...
[30:51.097] INFO Trying to join thread 1930017404...
[30:51.098] INFO Orphaned 'pipx', jumping off the mutex lock...
[30:51.098] INFO Shutting down plugin 'pipx'
[30:51.105] INFO Ended sub-interpreter...
[30:51.105] INFO Shut down plugin 'pipx'
[30:51.106] INFO Successfully joined thread
[30:51.106] INFO Successfully unloaded pipx
[30:51.108] INFO Enabled Plugins: 1, Loaded Plugins : 0
[30:51.109] INFO Starting backends...
[30:51.115] INFO Ports: { FTP: 8777, IPC: 8809 }
[30:51.116] INFO Plugins: { core: Enabled }
[30:51.116] INFO Plugins: { core: Enabled }
[30:51.117] INFO Starting backend for 'core'
[30:51.118] INFO Created thread 2551055591 for plugin 'core'
[30:51.148] INFO Redirecting stdout/stderr for plugin 'core'
[30:51.149] INFO Invoking plugin main callback for 'core'
[30:51.223] CORE Loading [email protected]
[30:53.073] INFO Connected to Steam @ 0x10f2f2b0
[30:53.077] INFO Connected to SharedJSContext in 4 ms
[30:53.078] INFO Preparing to inject frontend shims...
[30:53.613] CORE Starting the websocket for theme installer...
[30:53.614] CORE Ready in 2438.366 milliseconds!
[30:53.615] INFO Successfully loaded 'core'
[30:53.617] INFO Enabled Plugins: 1, Loaded Plugins : 1
[30:53.617] INFO Finished preparing backends...
[30:53.648] CORE Server started on ws://localhost:9123
[30:53.871] INFO Successfully sent debugger pause...
[30:55.347] INFO Debugger has paused!
[30:55.348] INFO Ready to inject shims!
[30:55.349] INFO Registering for load event @ 0x1256f970
[30:55.351] INFO Enabled Plugins: 1, Loaded Plugins : 1
[30:55.351] INFO Finished preparing backends...
[30:55.352] INFO Invoking & removing on load event @ 0x488cb58
[30:55.352] INFO Notifying frontend of backend load...
[30:55.462] INFO Successfully resumed debugger, injecting shims...
[30:55.471] INFO Successfully injected shims, updating state...
[30:55.471] INFO Successfully notified frontend...
[30:55.472] INFO Frontend notifier finished!
[30:57.835] CORE Using custom accent color
[30:57.865] CORE SteamUI successfully loaded!
[31:00.173] CORE Using custom accent color
[31:27.169] FFI-ERROR Failed to call updater.get_update_list():
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "D:\games/Steam/ext/data/assets/core\updater\version_control.py", line 22, in get_update_list
    self.process_updates()
  File "D:\games/Steam/ext/data/assets/core\updater\version_control.py", line 145, in process_updates
    self.remote_json = self.fetch_updates()
                       ^^^^^^^^^^^^^^^^^^^^
  File "D:\games/Steam/ext/data/assets/core\updater\version_control.py", line 133, in fetch_updates
    response = requests.post(
               ^^^^^^^^^^^^^^
  File "D:\games\Steam\ext\data\cache\Lib\site-packages\requests\api.py", line 115, in post
    return request("post", url, data=data, json=json, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\games\Steam\ext\data\cache\Lib\site-packages\requests\api.py", line 59, in request
    return session.request(method=method, url=url, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\games\Steam\ext\data\cache\Lib\site-packages\requests\sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\games\Steam\ext\data\cache\Lib\site-packages\requests\sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\games\Steam\ext\data\cache\Lib\site-packages\requests\adapters.py", line 633, in send
    conn = self.get_connection_with_tls_context(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\games\Steam\ext\data\cache\Lib\site-packages\requests\adapters.py", line 483, in get_connection_with_tls_context
    proxy_manager = self.proxy_manager_for(proxy)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\games\Steam\ext\data\cache\Lib\site-packages\requests\adapters.py", line 282, in proxy_manager_for
    manager = self.proxy_manager[proxy] = SOCKSProxyManager(
                                          ^^^^^^^^^^^^^^^^^^
  File "D:\games\Steam\ext\data\cache\Lib\site-packages\requests\adapters.py", line 64, in SOCKSProxyManager
    raise InvalidSchema("Missing dependencies for SOCKS support.")
requests.exceptions.InvalidSchema: Missing dependencies for SOCKS support.

[sdsvkz]

Workaround:

1. Go to "<Steam installation>\ext\data\cache"
2. Execute .\python.exe -m pip install PySocks

[shdwmtr]

You can PR and add PySocks, but I'll have to look at the implications of doing so for other users.
https://github.com/shdwmtr/millennium/blob/main/assets/requirements.txt

[sdsvkz]

You can PR and add PySocks, but I'll have to look at the implications of doing so for other users. https://github.com/shdwmtr/millennium/blob/main/assets/requirements.txt

@shdwmtr OK, I'll do it later.

Off-topic:
I think theme update process ignores system proxy? Is that intend? I'm not totally sure about that, but change this

millennium/assets/core/updater/version_control.py

Line 94 in 900b7eb

remote.fetch()

to

remote.fetch(proxy = True) # True to enable automatic proxy detection

immediately fixed my connection problem since I'm on Windows.

[shdwmtr]

You can PR both, I didn't have proxy support in mind when developing; forgot they existed.

Cheers!