Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Ensure millennium css is ordered after steam css #210

Open
2 tasks done
JunkiEDM opened this issue Jan 17, 2025 · 2 comments
Open
2 tasks done

[Suggestion] Ensure millennium css is ordered after steam css #210

JunkiEDM opened this issue Jan 17, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@JunkiEDM
Copy link

JunkiEDM commented Jan 17, 2025 •
edited
Loading

Before Requesting

  • I found no existing issue matching my feature request
  • This request is related to Millennium, and not a request for a specific theme/addon

Describe the feature you'd like!

After a long time using SFP, I'm trying out Millennium for its plugin support. I noticed that some themes weren't loading correctly since the css is loaded before the steam css, so you need to put !important after a lot of things you would need to otherwise, or else steam's default css will take over.
It's a relatively small change but it would be nice to have millennium css moved to the end of <head>, or after <body>, which is where the Stylus extension injects.

Anything else?

Millenium load order

Millenium load order

Stylus load order example

Stylus load order example - Github
@JunkiEDM JunkiEDM added the enhancement New feature or request label Jan 17, 2025
@shdwmtr
Copy link
Owner

shdwmtr commented Jan 17, 2025

What themes aren't loading correctly

@JunkiEDM
Copy link
Author

JunkiEDM commented Jan 19, 2025 •
edited
Loading

This one I made is the main one I noticed, it's just a snippet for more compact webkit context menus: compact-menu-webkit.css

Expected (SFP):
Image

Millennium:
Image

in devtools

Image

adding !important to everything would technically solve this but that feels like more of a workaround than a solution

@JunkiEDM JunkiEDM changed the title [Suggestion] Ensure millennium css is injected after steam css [Suggestion] Ensure millennium css is ordered after steam css Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JunkiEDM @shdwmtr