Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize loading UI for reusability #24

Closed
otech47 opened this issue Jan 8, 2019 · 1 comment
Closed

Optimize loading UI for reusability #24

otech47 opened this issue Jan 8, 2019 · 1 comment
Assignees

Comments

@otech47
Copy link
Member

otech47 commented Jan 8, 2019

See #15 (comment)

@otech47
Copy link
Member Author

otech47 commented Jan 14, 2019

Here's a possible implementation

Sample reducer:

const DECREMENT_PENDING_NETWORK_CALLS = 'environment/DECREMENT_PENDING_NETWORK_CALLS';
const INCREMENT_PENDING_NETWORK_CALLS = 'environment/INCREMENT_PENDING_NETWORK_CALLS';
const RESET_PENDING_NETWORK_CALLS = 'environment/RESET_PENDING_NETWORK_CALLS';

// Reducer
const initialState = {
    pendingNetworkCalls: 0
};

// Actions
import api from '../scripts/api';

export function decrementPendingNetworkCalls() {
    return {
        type: DECREMENT_PENDING_NETWORK_CALLS
    };
}

export function incrementPendingNetworkCalls() {
    return {
        type: INCREMENT_PENDING_NETWORK_CALLS
    };
}

export function resetPendingNetworkCalls() {
    return {
        type: RESET_PENDING_NETWORK_CALLS
    };
}

export default function reducer(state = initialState, action) {
    switch (action.type) {
    case DECREMENT_PENDING_NETWORK_CALLS:
        return {
            ...state,
            pendingNetworkCalls: state.pendingNetworkCalls - 1
        };
    case INCREMENT_PENDING_NETWORK_CALLS:
        return {
            ...state,
            pendingNetworkCalls: state.pendingNetworkCalls + 1
        };
    case RESET_PENDING_NETWORK_CALLS:
        return {
            ...state,
            pendingNetworkCalls: 0
        };
    default:
        return state;
    }
}

Sample Loader UI

import React from 'react';
import { connect } from 'react-redux';
import { BarLoader } from 'react-css-loaders'

import Flex from './Flex'
import theme from '../styles/theme'

const Loader = ({ color, size, show }) => {
    return show && (
        <Flex
            position='fixed'
            top={0}
            left={0}
            width='100vw'
            height='100vh'
            bg='overlay'
            zIndex={1000}
            center
        >
            <BarLoader color={color} size={size}/>
        </Flex>
    )
}

Loader.defaultProps = {
    color: theme.colors.white,
    size: 8
}

const mapStateToProps = ({ environment }) => {
    return {
        show: environment.pendingNetworkCalls > 0,
    };
};

export default connect(mapStateToProps)(Loader);

Sample Usage

import {
    decrementPendingNetworkCalls,
    incrementPendingNetworkCalls,
    resetPendingNetworkCalls
} from './environment'

export function fetchData() {
    return (dispatch) => {
        
        dispatch(incrementPendingNetworkCalls())
        return (
            api.graph(...)
            .then(res => {
                dispatch(decrementPendingNetworkCalls())
            })
            .catch(err => {
                console.error(err)
                dispatch(resetPendingNetworkCalls())
            })
        )
    }
}

@FedeMadoery FedeMadoery self-assigned this Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants