-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPRT LLR calculation #34
Comments
I think maybe it's because I'm testing likelihood that θ = θ1 not θ > θ1 |
Yeah we don't care if it's exactly 35 ELO better, only that is 35 or more better. On the lower end test we'd tweaked it to test at 0 since if it's under 0 we don't care if it's -5 or -75, so why waste time figuring out if it's better or worse than -35. |
Past discussions that might help (or not). leela-zero/leela-zero#378 |
It appears fishtest also uses my methodology. https://github.com/glinscott/fishtest/blob/master/fishtest/fishtest/stat_util.py#L112 |
The author michel van den bergh has a bunch of comments on github and talkchess |
I'm writing SPRT calculator and I'm confused by the sprt math.
I wrote up the three methods I know in this gist
LLF = my optimized version
wiki = my take on likelihood-ratio_test
LLR = the code from leela-zero-server
Other links:
https://www.chessprogramming.org/Match_Statistics#SPRT
^ uses similar math to this repo but with draws
^ draws it's justification from http://hardy.uhasselt.be/Toga/GSPRT_approximation.pdf
https://nowak.ece.wisc.edu/ece830/ece830_fall11_lecture9.pdf
^ maybe I'm misunderstanding p0(x) and p1(x)
The text was updated successfully, but these errors were encountered: