Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type definition - ExcelCell #141

Open
samuelhulla opened this issue Oct 16, 2020 · 0 comments · May be fixed by #143
Open

Incorrect type definition - ExcelCell #141

samuelhulla opened this issue Oct 16, 2020 · 0 comments · May be fixed by #143

Comments

@samuelhulla
Copy link

samuelhulla commented Oct 16, 2020

Hello, I actually ran across this randomly while answering a question on stackoverflow, but either way

The current the typescript definition for ExcelCell is incorrect

(and retro-actively where it's used)

Current definition:

interface ExcelCell {
    value: ExcelCell;
    style: ExcelStyle;
}

This obviously makes no sense and would require you to recursively declare the ExcelCell inside the value property.

Supposed to be

interface ExcelCell {
    value: ExcelCellValue;
    style: ExcelStyle;
}
samuelhulla added a commit to samuelhulla/react-data-export that referenced this issue Oct 16, 2020
This was referenced Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant