New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some of the Python code might be not run #36

Open

saiwing-yeung opened this issue Jul 7, 2022 · 0 comments

saiwing-yeung commented Jul 7, 2022

I noticed that some Python code might not run as is. For example, in https://github.com/scunning1975/mixtape/blob/master/python/synth_1.py, it looks like we need:

To import robjects, IntVector, plt
To import pandas2ri and call pandas2ri.activate() so that the dataframe texas would get converted

I have only looked at the code from the synthetic control chapter. I can make a PR for this.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment