Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

Tests are missing for histograms #15

Open
HDembinski opened this issue Dec 13, 2018 · 3 comments
Open

Tests are missing for histograms #15

HDembinski opened this issue Dec 13, 2018 · 3 comments

Comments

@HDembinski
Copy link
Member

Histograms are completely untested, and the current implementation of TH1 methods has bugs.

@HDembinski
Copy link
Member Author

I wrote a little test that I am happy to submit, but it relies on the other PRs that I made, so I would make a separate PR for this new test, after the other PRs are merged.

@HDembinski
Copy link
Member Author

More tests should be added later, but it is a start.

@jpivarski
Copy link
Member

I've merged the PRs so we're ready for your tests, which would be gladly appreciated! These gaps in testing are a serious problem. However, it's probably evening where you are, and I want to assign a version number of 0.3.0 so that I can move on to getting uproot ready for it. I think we'll need to put them into 0.3.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants