Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of OK button tag in inputgui.m #829

Open
UchidaHitoshi opened this issue Nov 21, 2024 · 1 comment
Open

Incorrect handling of OK button tag in inputgui.m #829

UchidaHitoshi opened this issue Nov 21, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@UchidaHitoshi
Copy link

Description

There is a problem with the tag property of the OK button in the processing described in the functions/guifunc/inputgui.m file.

Because the following two different methods are mixed, it may not be possible to detect that the OK button has been pressed. Specifically, the Cleanline plugin does not work with EEGLAB 2024.2.

  1. Using the value of the g.okbut variable as the value of the tag property
  2. The fixed string "ok" is used as the value of the tag property.

In addition, inputgui.m sets the default value of g.okbut to "OK" in the upper case, which can cause problems if you use the value of the g.okbut variable as the value of the tag property.

The Text of the Push Button Object is rewritten in supergui.m with only the first character being uppercase and the second and subsequent characters being lowercase, so the value that was "OK" before the Figure was displayed is "Ok" when the Figure is displayed. Therefore, if you press the OK button and then try to use findobj to retrieve data whose tag property is "OK", you will fail.


EEGLAB version [2024.2]
@arnodelorme
Copy link
Collaborator

Correct. Thanks for reporting. We are working on the issue.

@arnodelorme arnodelorme self-assigned this Jan 23, 2025
@arnodelorme arnodelorme added the bug Something isn't working label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants